Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnusedArgument] Ignore arguments defined in a nested class #71

Conversation

nvasilevski
Copy link
Contributor

This is a very similar issue to argument & field uniqueness
Since we are looking for any argument :arg definitions in the top-level class we get every definition even if it's declared in a nested class
To prevent this I'm adding filtering to make sure that we only analyze arguments defined on the same class that is being parsed by comparing it with the node argument

on_class method was violating method complexity cop so I had to define a new method

Copy link
Owner

@DmitryTsepelev DmitryTsepelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DmitryTsepelev DmitryTsepelev merged commit cb86755 into DmitryTsepelev:master Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants